[core] Fix data-evolution row count should be more accurate. #6489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
force-pushed
the
row_count
branch
from
a20b9b3 to
3117a9c
Compare
JingsongLi
reviewed
Oct 30, 2025
| deltaRecordCount = nextRowIdStart - firstRowIdStart; | ||
| totalRecordCount = nextRowIdStart; | ||
| } else { | ||
| deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles); |
There was a problem hiding this comment.
I think we don't need to modify here, we should also modify split row count just like python.
There was a problem hiding this comment.
Maybe we can modify here too, it depends on how it defines
|
Should we also modify split row count just like python? |
leaves12138
force-pushed
the
row_count
branch
from
61f3ed0 to
ee9669e
Compare
Sure~ Fixed as requested~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Data evolution table total records in snapshot should be more accurate
Tests
API and Format
Documentation