[spark] Fix Comaptibility in getting NamedReference from spark32 to spark35 #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
requested changes
Aug 15, 2024
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Please add test to cover spark32.
JingsongLi
reviewed
Aug 15, 2024
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Try to PaimonPushDownTest => PaimonPushDownTestBase, add this to 3.2
Member
Author
Paimon 3.2 version is from 3.2.4 and 3.2.4 is no problem about it. this is 3.2.4 and 3.2.0 version code，if support 3.2.0+ this api need to be changed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Comaptibility in getting NamedReference from spark32 to spark35 with a common api to get NamedReference
spark3.3+ ：
spark3.2：
then sql would error out as ：
Linked issue: close #xxx
Tests
API and Format
Documentation