[flink] CDC Ingestion supported metadata columns #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsterChenzhuo
force-pushed
the
meta
branch
from
697c743 to
fafa050
Compare
MonsterChenzhuo
changed the title
MonsterChenzhuo
force-pushed
the
meta
branch
from
fafa050 to
fb760c8
Compare
MonsterChenzhuo
changed the title
MonsterChenzhuo
force-pushed
the
meta
branch
2 times, most recently
from
c197aa7 to
92c26ea
Compare
MonsterChenzhuo
force-pushed
the
meta
branch
from
92c26ea to
2c9e22e
Compare
MonsterChenzhuo
changed the title
Contributor
|
Please rebase master |
Contributor
Author
|
@JingsongLi PTAL,thanks. |
JingsongLi
requested changes
Oct 7, 2023
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @MonsterChenzhuo , left some minor comments.
|
|
||
| @Override | ||
| public Map<String, String> read(JsonNode record) { | ||
| String dbName = |
|
|
||
| @Override | ||
| public Map<String, String> read(JsonNode record) { | ||
| String dbName = |
| */ | ||
| public interface CdcMetadataConverter extends Serializable { | ||
|
|
||
| Map<String, String> read(JsonNode var1); |
Contributor
There was a problem hiding this comment.
var1 to a meaningful name
| computedColumn.eval(resultMap.get(computedColumn.fieldReference()))); | ||
| } | ||
|
|
||
| for (CdcMetadataConverter metadataConverters : metadataConverters) { |
| record.get("source").get(AbstractSourceInfo.TABLE_NAME_KEY).asText(); | ||
| Map<String, String> resultMap = new HashMap<>(); | ||
| resultMap.put("table_name", dbName); | ||
| return resultMap; |
Contributor
There was a problem hiding this comment.
Collections.singletonMap
| record.get("source").get(AbstractSourceInfo.DATABASE_NAME_KEY).asText(); | ||
| Map<String, String> resultMap = new HashMap<>(); | ||
| resultMap.put("database_name", dbName); | ||
| return resultMap; |
Contributor
There was a problem hiding this comment.
Collections.singletonMap
| record.get("source").get(AbstractSourceInfo.TIMESTAMP_KEY).asText(); | ||
| Map<String, String> resultMap = new HashMap<>(); | ||
| resultMap.put("op_ts", dbName); | ||
| return resultMap; |
Contributor
There was a problem hiding this comment.
Collections.singletonMap
pongandnoon
added a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 04179e3) # Conflicts: # paimon-core/src/main/java/org/apache/paimon/utils/JsonSerdeUtil.java # paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/kafka/KafkaSyncTableAction.java # paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mongodb/MongoDBSyncTableAction.java
pongandnoon
pushed a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 04179e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
close #1985
Tests
MySqlSyncDatabaseActionITCase#testMetadataColumns()
MySqlSyncTableActionITCase#testMetadataColumns()
API and Format
Documentation