Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec): Impl the ManifestFile read functionality #69

Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat(spec): Impl the ManifestFile read functionality #69

merged 5 commits into from
Sep 9, 2024

Conversation

Aitozi
Copy link
Contributor

@Aitozi Aitozi commented Sep 6, 2024 •
edited
Loading

close #61

Xuanwo
Xuanwo reviewed Sep 6, 2024
View reviewed changes
crates/paimon/src/spec/data_file.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/data_file.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/manifest_entry.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/objects_file.rs Outdated Show resolved Hide resolved
@Aitozi Aitozi requested a review from Xuanwo September 9, 2024 02:12
Xuanwo
Xuanwo approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Aitozi
Copy link
Contributor Author

Aitozi commented Sep 9, 2024

CC @JingsongLi

SteNicholas
SteNicholas approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas SteNicholas merged commit 4275c6b into apache:main Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@SteNicholas SteNicholas SteNicholas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spec: Impl the ManifestFile read functionality
3 participants
@Aitozi @Xuanwo @SteNicholas