HDDS-3479. Use SCMMetadataStore high level abstraction instead of DBS… #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 26, 2020 14:35
…toreBuilder and SCMDBDefinition directly HDDS-3479. Rename SCMMetadataStoreRDBImpl to SCMMetadataStoreImpl as it is not longer RocksDB specific.
Contributor
Author
|
The acceptance check has some errors, specifically, test cases related to S3 in this part Run cd /mnt/ozone/compose && ./test-all.sh. I don't think these errors are caused by the changes introduced in this PR. |
elek
approved these changes
Jun 24, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1
Thanks the patch @jsoft88 (And sorry for the late review).
One NIT: There are two lines which are commented out: I would prefer to remove them
Pushed the removal and a rebase to your fork (to make the merge faster). Will merge it after a green build.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…toreBuilder and SCMDBDefinition directly
HDDS-3479. Rename SCMMetadataStoreRDBImpl to SCMMetadataStoreImpl as it is not longer RocksDB specific.
What changes were proposed in this pull request?
Use ScmMetadataStore everywhere inside SCM instead of DBStoreBuilder with separated DB definition (SCMDBDefinition)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3479?jql=project%20in%20(HDDS)%20AND%20labels%20in%20(newbie)%20AND%20assignee%20is%20EMPTY%20AND%20status%20in%20(open%2C%20Reopened)
How was this patch tested?
By executing test.sh under dist/