-
Notifications
You must be signed in to change notification settings - Fork 615
HDDS-3638. Add a cat command to show the text of a file in the Ozone server #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4aae18f
HDDS-3638. Add a cat command to show the text of a file in the Ozone …
maobaolong 2ff279f
Update hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell…
maobaolong 0867318
HDDS-3638. Address comments, modify the default chunk size.
maobaolong 7b656cc
HDDS-3605. Address comments, 4kb buffer.
maobaolong 0d05ac8
HDDS-3605. Address comments, 4kb buffer.
maobaolong 2ac8bd7
trigger new CI check
adoroszlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
60 changes: 60 additions & 0 deletions
60
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/CatKeyHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.shell.keys; | ||
|
|
||
| import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_CHUNK_SIZE_DEFAULT; | ||
| import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_CHUNK_SIZE_KEY; | ||
|
|
||
| import org.apache.hadoop.conf.StorageUnit; | ||
| import org.apache.hadoop.io.IOUtils; | ||
| import org.apache.hadoop.ozone.client.OzoneBucket; | ||
| import org.apache.hadoop.ozone.client.OzoneClient; | ||
| import org.apache.hadoop.ozone.client.OzoneClientException; | ||
| import org.apache.hadoop.ozone.client.OzoneVolume; | ||
| import org.apache.hadoop.ozone.shell.OzoneAddress; | ||
| import picocli.CommandLine.Command; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
|
|
||
| /** | ||
| * Cat an existing key. | ||
| */ | ||
| @Command(name = "cat", | ||
| description = "Cat a specific key from ozone server") | ||
| public class CatKeyHandler extends KeyHandler { | ||
|
|
||
| @Override | ||
| protected void execute(OzoneClient client, OzoneAddress address) | ||
| throws IOException, OzoneClientException { | ||
|
|
||
| String volumeName = address.getVolumeName(); | ||
| String bucketName = address.getBucketName(); | ||
| String keyName = address.getKeyName(); | ||
|
|
||
| int chunkSize = (int) getConf().getStorageSize(OZONE_SCM_CHUNK_SIZE_KEY, | ||
| OZONE_SCM_CHUNK_SIZE_DEFAULT, StorageUnit.BYTES); | ||
|
|
||
| OzoneVolume vol = client.getObjectStore().getVolume(volumeName); | ||
| OzoneBucket bucket = vol.getBucket(bucketName); | ||
| try (InputStream input = bucket.readKey(keyName)) { | ||
| IOUtils.copyBytes(input, System.out, chunkSize); | ||
|
maobaolong marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.