Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • HDDS-11981 added new annotations in OM without banning them where they should be.
  • Annotations defined on ozone-manager are not available in modules that do not depend on ozone-manager, so they do not need to be banned.
  • Similarly, Replicate defined in hdds-server-framework does not need to be banned in common/client modules.

https://issues.apache.org/jira/browse/HDDS-14216

How was this patch tested?

Local and CI build.

https://github.com/adoroszlai/ozone/actions/runs/20371326384/job/58538399302

@adoroszlai adoroszlai self-assigned this Dec 19, 2025
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Dec 19, 2025
@rich7420
Copy link
Contributor

@adoroszlai thanks for the patch! LGTM

@adoroszlai adoroszlai requested a review from fapifta December 21, 2025 13:03
Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @adoroszlai thanks for the patch

@adoroszlai adoroszlai merged commit 1c7e528 into apache:master Dec 22, 2025
42 checks passed
@adoroszlai adoroszlai deleted the HDDS-14216 branch December 22, 2025 15:49
@adoroszlai
Copy link
Contributor Author

Thanks @rich7420, @swamirishi for the review.

@rich7420
Copy link
Contributor

@adoroszlai , @swamirishi thanks!

echonesis pushed a commit to echonesis/ozone that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull request that modifies the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants