HDDS-14013. Release stream resources in StreamBlockInputStream properly #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterxcli
reviewed
Nov 26, 2025
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java
Show resolved
Hide resolved
peterxcli
changed the title
Contributor
|
Thanks @chungen0126 for the patch, @peterxcli for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Here is a commit from #6613. See #6613 (comment).
This is about release resources properly.
In
StreamBlockInputStream, thegetAndSet(true)returns the previous value,wasNotYetCompletewould be false the first time it's called. This could cause releaseStreamResources() to be skipped the first time it's called.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14013
How was this patch tested?
https://github.com/chungen0126/ozone/actions/runs/19693146030