HDDS-13974. Use the same gRPC steam for reading the same block. #9369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… offsets to be calculated correctly on the client
… on many tests to allow it to compile
…w checksum offsets to be calculated correctly on the client" This reverts commit 1f90a0a.
szetszwo
commented
Nov 26, 2025
Contributor
Author
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
|
Thanks @szetszwo for the patch. A commit is missing here (#6613 (comment)). It's about releasing resources properly. Created a jira ticket for this (https://issues.apache.org/jira/browse/HDDS-14013). |
Contributor
Author
|
@chungen0126 , I have merged only up to 726f8e4 as mentioned in #6613 (comment) For further works, please wait for HDDS-13975. It is bigger change that we should merge first. Otherwise, it will keep getting conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In HDDS-13973, sendCommandReadBlock(..) creates a new gRPC stream per read(..) call but not a single stream per block. If the application code uses small (e.g. 64KB) buffer, then it is going to create a lot of gRPC streams.
It should keep using the same gRPC connection for streaming a block.
Note that the code is merged from #6613 up to 726f8e4 by @sodonnel
What is the link to the Apache JIRA
HDDS-13974
How was this patch tested?
Updating existing tests