HDDS-13944. S3G Metrics support displaying Netty off-heap memory#9309
Merged
adoroszlai merged 2 commits intoapache:masterfrom Nov 18, 2025
Merged
HDDS-13944. S3G Metrics support displaying Netty off-heap memory#9309adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Nov 17, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ivandika3 for the patch. Netty part looks good.
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/Gateway.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Nov 17, 2025
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
looks good except for the Attila finding.
adoroszlai
approved these changes
Nov 18, 2025
Contributor
|
Thanks @ivandika3 for the patch, @jojochuang for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We encountered high OS memory in S3G although heap seems to be normal, we can check Netty memory to see if the issue comes from Netty off-heap memory.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13944
How was this patch tested?
CI: https://github.com/ivandika3/ozone/actions/runs/19419307988