HDDS-13883. Support HTTPS with ozone insight command#9285
HDDS-13883. Support HTTPS with ozone insight command#9285adoroszlai merged 5 commits intoapache:masterfrom
Conversation
|
@errose28 requesting you to review this PR. |
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for the patch.
hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/BaseInsightSubCommand.java
Outdated
Show resolved
Hide resolved
|
Can we add integration or acceptance tests to verify that the connection can actually be created after the configs are resolved? |
Added a Robot test that runs in both secure and unsecure clusters. The |
Is that because of the higher heartbeat interval? |
Thanks for the suggestion. After setting the heartbeat interval config to 5s, the logs started appearing much faster. I’ve now reduced the timeout accordingly. |
|
@errose28 would you like to take another look? |
|
Thanks @sarvekshayr for the patch, @errose28 for the review. |
What changes were proposed in this pull request?
The
ozone insightcommand only supported HTTP connections. This PR adds HTTPS support by checking theozone.http.policyconfiguration and selecting the protocol (HTTP/HTTPS) and port (9876/9877 for SCM, 9874/9875 for OM) based on the configured HTTP policy.What is the link to the Apache JIRA
HDDS-13883
How was this patch tested?
Added a new unit test class
TestBaseInsightSubCommandto test the host resolution logic inBaseInsightSubCommand.Added robot test
ozone-insight.robotto run in both secure and unsecure clusters.Tested manually in ozonesecure docker cluster: