HDDS-13907. Prune ACLs from OmKeyInfo before building purge requests in DirectoryDeletingService#9275
Merged
swamirishi merged 4 commits intoapache:masterfrom Nov 11, 2025
Merged
Conversation
aswinshakil
reviewed
Nov 10, 2025
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Nov 10, 2025
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
adoroszlai
changed the title
Contributor
|
Thanks @aryangupta1998 for updating the patch. Marked as draft because several tests have failed with each version of the patch. Can you please check them? https://github.com/aryangupta1998/hadoop-ozone/actions/runs/19241734654 |
added 3 commits
November 11, 2025 18:50
… requests in DirectoryDeletingService.
aryangupta1998
force-pushed
the
HDDS-13907
branch
from
e6c45b0 to
29eb833
Compare
swamirishi
approved these changes
Nov 11, 2025
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
LGTM thanks for the patch @aryangupta1998. Do you think we can add some unit test for this?
Contributor
Author
|
@swamirishi sure, will add a unit test in a follow up jira! |
Contributor
|
thank you @aswinshakil @adoroszlai for reviewing the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During directory deletion, ACL information stored in OmKeyInfo objects is unnecessary for purge operations and can increase memory and log payload size. This change clears ACLs from all OmKeyInfo instances collected in purge requests to optimize memory usage and reduce unnecessary data serialization.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13907
How was this patch tested?
Tested Manually.