Skip to content

Conversation

@sarvekshayr
Copy link
Contributor

What changes were proposed in this pull request?

See #7096

Currently we have a custom label that is manually applied to pull requests to mark them for auto closing, after which an auto-close action will come in later. Since this workflow seems to be leaving a lot of old PRs open, this Jira is to replace this workflow with https://github.com/actions/stale which does a similar thing but is completely automated.

What is the link to the Apache JIRA

HDDS-11370

How was this patch tested?

Tested on my fork.

PR marked as stale: sarvekshayr#47
close-stale-prs CI: https://github.com/sarvekshayr/ozone/actions/runs/19161704140

@sarvekshayr
Copy link
Contributor Author

@errose28 @adoroszlai please review this change.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarvekshayr for the patch, LGTM.

@sarvekshayr
Copy link
Contributor Author

Should we consider increasing the number of days before marking it stale? Right now it’s set to 21 days of inactivity, which might be a bit aggressive.

cc: @ChenSammi

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but overall LGTM. Thanks @sarvekshayr for picking this up.

IMO the time windows are good. After 3 weeks of inactivity both reviewers and author will get a ping, at which point they can reconnect to decide what should happen to the PR. A simple comment by the author re-requesting a review would be enough to move it out of stale state. If nobody responds for another week then the PR is closed, which serves as more of a second ping than a final decision since it can still be re-opened at any time after that.

@adoroszlai adoroszlai merged commit 78490e9 into apache:master Nov 10, 2025
15 checks passed
@adoroszlai
Copy link
Contributor

Thanks @sarvekshayr for the patch, @errose28 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants