HDDS-13868. Add unit test coverage for OMNodeDetails#9245
Merged
jojochuang merged 5 commits intoapache:masterfrom Nov 5, 2025
Merged
HDDS-13868. Add unit test coverage for OMNodeDetails#9245jojochuang merged 5 commits intoapache:masterfrom
jojochuang merged 5 commits intoapache:masterfrom
Conversation
jojochuang
reviewed
Nov 4, 2025
| assertEquals(nodeId, nodeDetails.getNodeId()); | ||
| assertEquals(9862, nodeDetails.getRpcPort()); | ||
| assertEquals(9873, nodeDetails.getRatisPort()); | ||
| } |
Contributor
There was a problem hiding this comment.
Can you add two negative tests here
Suggested change
| } | |
| nodeDetails = OMNodeDetails.getOMNodeDetailsFromConf(conf, serviceId, null); | |
| assertNull(nodeDetails); | |
| nodeDetails = OMNodeDetails.getOMNodeDetailsFromConf(conf, null, nodeId); | |
| assertNull(nodeDetails); | |
| } |
Contributor
Author
There was a problem hiding this comment.
@jojochuang Thank you for your suggestion. I think we could put this two negative test to testGetOMNodeDetailsFormConfMissing(). Is this a good way?
Contributor
Author
|
Thank you @jojochuang . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds unit tests for the OMNodeDetails class.
Added test file: TestOMNodeDetails.java with 16 test methods covering major functionality.
Please describe your PR in detail:
Test Coverage
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13868
How was this patch tested?
mvn test -Dtest=TestOMNodeDetails -pl hadoop-ozone/common