HDDS-13485. Reduce duplication between ContainerSafeModeRule tests#9194
Merged
adoroszlai merged 1 commit intoapache:masterfrom Nov 3, 2025
Merged
HDDS-13485. Reduce duplication between ContainerSafeModeRule tests#9194adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
sarvekshayr
approved these changes
Oct 27, 2025
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks for the patch @kousei47747.
LGTM.
adoroszlai
approved these changes
Nov 3, 2025
Contributor
|
Thanks @kousei47747 for the patch, @sarvekshayr for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extract an abstract parent class to reduce the duplication between TestECContainerSafeModeRule and TestRatisContainerSafeModeRule.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13485
How was this patch tested?
Unit test.