HDDS-13831. Refine set role logic in getServicelist#9191
Merged
ivandika3 merged 1 commit intoapache:masterfrom Oct 31, 2025
Merged
HDDS-13831. Refine set role logic in getServicelist#9191ivandika3 merged 1 commit intoapache:masterfrom
ivandika3 merged 1 commit intoapache:masterfrom
Conversation
ChenSammi
approved these changes
Oct 30, 2025
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
The change looks good.
Contributor
Author
|
@ChenSammi @ivandika3 Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the OM processing the getServiceList() request is set to be the "Leader" because all requests will be forwarded to the leader.
But after supporting read from follower, this logic will show incorrect role information.
This ticket is to refine the logic, so that it will show the correct role after supporting follower-read.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13831
How was this patch tested?
Existing tests.