HDDS-499. Display descriptions for properties on the configuration page#9152
Merged
adoroszlai merged 4 commits intoapache:masterfrom Nov 19, 2025
Conversation
Contributor
Author
|
Hi @devabhishekpal, can you please review this PR? |
devabhishekpal
approved these changes
Oct 31, 2025
Contributor
devabhishekpal
left a comment
devabhishekpal
left a comment
There was a problem hiding this comment.
Thanks for the change @ptlrs
This LGTM, +1
Contributor
Author
|
Thanks for the review @devabhishekpal. @errose28 @adoroszlai can you please take a look and help to merge this? |
adoroszlai
reviewed
Nov 7, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ptlrs for the patch.
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
Outdated
Show resolved
Hide resolved
…y description display on the configuration page
…ation-page-does-not-show-description # Conflicts: # hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
Contributor
Author
|
Thanks for the review @adoroszlai. I have updated the code with the changes. |
…ion-page-does-not-show-description
Contributor
|
thanks @ptlrs for the patch, @devabhishekpal for the review. |
ptlrs
deleted the
HDDS-499-Configuration-page-does-not-show-description
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the properties are read by the internal hadoop libraries from the config files, they return a simple hashmap of keys and values. It maybe more complex to update that code to also return descriptions. As a workaround, we reads the config files and extract the configuration descriptions separately.
This PR:
Note: You may need to disable the cache from developer tools to see the effect of these changes locally.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-499
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/18490389759