HDDS-13779. Correctly initialize the bootstrap lock in OMDBCheckpointServletInodeBasedXfer. #9142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ServletInodeBasedXfer.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes proper initialization of the bootstrap lock in OMDBCheckpointServletInodeBasedXfer to prevent concurrency issues during checkpoint operations.
- Adds proper bootstrap lock initialization in the servlet's init() method
- Implements the getBootstrapStateLock() method to return the lock instance
- Adds comprehensive unit tests to verify lock coordination between checkpoint operations and background services
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OMDBCheckpointServletInodeBasedXfer.java | Adds bootstrap lock field initialization and getter method implementation |
| TestOMDbCheckpointServletInodeBasedXfer.java | Adds unit tests for bootstrap lock coordination and blocking behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...n-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java
Show resolved
Hide resolved
...n-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java
Show resolved
Hide resolved
swamirishi
approved these changes
Oct 13, 2025
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
LGTM @sadanand48 thanks for the patch
Contributor
|
Merged. Thanks @sadanand48 @swamirishi |
Contributor
|
Thanks @sadanand48 for the patch. |
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
Nov 19, 2025
…eckpointServletInodeBasedXfer. (apache#9142)" This reverts commit 4e5e5a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Proper initialization of bootstap lock in OMDBCheckpointServletInodeBasedXfer.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13779
How was this patch tested?
Unit tests