HDDS-13699. Possible Netty version mismatch in ozone-filesystem-shaded#9052
Merged
adoroszlai merged 1 commit intoapache:masterfrom Sep 21, 2025
Merged
HDDS-13699. Possible Netty version mismatch in ozone-filesystem-shaded#9052adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
szetszwo
approved these changes
Sep 20, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone and Ratis both depend on Netty, possibly different versions. Ratis shades Netty, so version mismatch should not cause any problems. However, HDDS-12462 changed usage of Netty native libraries in Ozone FS Shaded jars, adding libs from Ozone-specific version of Netty for Ratis. This causes runtime error if Netty in Ozone is ahead of the one in Ratis, e.g. if Ozone FileSystem fat jar is used in secure environment:
With this PR, we add both sets of native libraries to the shaded jar.
https://issues.apache.org/jira/browse/HDDS-13699
How was this patch tested?
Reproduced the problem by upgrading Netty only in Ozone, but not in Ratis (9d099d7):
https://github.com/adoroszlai/ozone/actions/runs/17860737460
Same setup passes with the fix:
https://github.com/adoroszlai/ozone/actions/runs/17860948466
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/17860959201