Skip to content

HDDS-13689. Remove unnecessary usage of Guava from ozonefs#9044

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-13689
Sep 18, 2025
Merged

HDDS-13689. Remove unnecessary usage of Guava from ozonefs#9044
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-13689

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

OzoneFileSystem and RootedOzoneFileSystem use Strings.isNullOrEmpty unnecessarily, Boolean.parseBoolean already handles both cases (null and empty).

$ jshell

jshell> Boolean.parseBoolean(null)
$1 ==> false

jshell> Boolean.parseBoolean("")
$2 ==> false

jshell> Boolean.parseBoolean("asdf")
$3 ==> false

jshell> Boolean.parseBoolean("false")
$4 ==> false

jshell> Boolean.parseBoolean("true")
$5 ==> true

https://issues.apache.org/jira/browse/HDDS-13689

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/17801676456

@adoroszlai adoroszlai self-assigned this Sep 17, 2025
@adoroszlai adoroszlai added the code-cleanup Changes that aim to make code better, without changing functionality. label Sep 17, 2025
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 053b554 into apache:master Sep 18, 2025
42 checks passed
@adoroszlai
Copy link
Contributor Author

Thanks @ayushtkn for the review.

@adoroszlai adoroszlai deleted the HDDS-13689 branch September 18, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-cleanup Changes that aim to make code better, without changing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants