Skip to content

HDDS-13624. Close ManagedWriteOptions while DBStoreBuilder.build fails to get DB store #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Sep 19, 2025
Merged

HDDS-13624. Close ManagedWriteOptions while DBStoreBuilder.build fails to get DB store #9039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73aa06
getting db and check befor writeOptions creation.
priyeshkaratha Sep 16, 2025
efee9c7
handling constructor fails for any reason
priyeshkaratha Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,24 +207,32 @@ public RDBStore build() throws RocksDatabaseException {
}

Set<TableConfig> tableConfigs = makeTableConfigs();

ManagedWriteOptions writeOptions = null;
try {
if (rocksDBOption == null) {
rocksDBOption = getDefaultDBOptions(tableConfigs);
}
setDBOptionsProps(rocksDBOption);
ManagedWriteOptions writeOptions = new ManagedWriteOptions();
writeOptions.setSync(rocksDBConfiguration.getSyncOption());

File dbFile = getDBFile();
if (!dbFile.getParentFile().exists()) {
throw new RocksDatabaseException("The DB destination directory should exist.");
}
writeOptions = new ManagedWriteOptions();
writeOptions.setSync(rocksDBConfiguration.getSyncOption());

return new RDBStore(dbFile, rocksDBOption, statistics, writeOptions, tableConfigs,
openReadOnly, dbJmxBeanNameName, enableCompactionDag,
maxDbUpdatesSizeThreshold, createCheckpointDirs, configuration,
enableRocksDbMetrics);
} catch (Exception ex) {
try {
if (writeOptions != null) {
writeOptions.close();
}
} catch (Exception suppressed) {
ex.addSuppressed(suppressed);
}
throw ex;
} finally {
tableConfigs.forEach(TableConfig::close);
}
Expand Down