HDDS-13678. Refactor presigned URL integration tests#9037
Merged
ivandika3 merged 5 commits intoapache:masterfrom Sep 17, 2025
Merged
HDDS-13678. Refactor presigned URL integration tests#9037ivandika3 merged 5 commits intoapache:masterfrom
ivandika3 merged 5 commits intoapache:masterfrom
Conversation
- Use @nested to group presigned URL tests - Remove duplicated code and object setup - Extract openHttpURLConnection method for reuse
peterxcli
added
test
s3
ivandika3
approved these changes
Sep 16, 2025
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks for streamlining the tests. LGTM +1.
Contributor
Author
|
Thanks @ivandika3 for the review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor test cases for better organization and code reuse.
Please describe your PR in detail:
@Nestedfor clearer test structure.SdkHttpClientcreationS3PresignercreationDurationfor presigned url expirationopenHttpURLConnection) for reuse across tests.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13678
How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/17721451820