Skip to content

HDDS-13542. Separate out the API calls for Overview page#9033

Merged
ArafatKhan2198 merged 7 commits intoapache:masterfrom
devabhishekpal:HDDS-13542
Sep 17, 2025
Merged

HDDS-13542. Separate out the API calls for Overview page#9033
ArafatKhan2198 merged 7 commits intoapache:masterfrom
devabhishekpal:HDDS-13542

Conversation

@devabhishekpal
Copy link
Contributor

@devabhishekpal devabhishekpal commented Sep 15, 2025

What changes were proposed in this pull request?

HDDS-13542. Separate out the API calls for Overview page

Please describe your PR in detail:

  • Currently the API calls in the Overview page is clubbed together using a AllSettled method which waits for all the API calls to resolve before updating the results - this blocks the page on the slowest API call.
  • This PR aims to decouple the requests into separate API calls such that we update the page as soon as the calls resolve one by one.
  • It also adds error handling in case the API call returns an error or the call is not able to be made/
  • Apart from this we introduce a new API hook that can be used to make the calls and also convert the AutoReloadHelper into a hook format.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13542

How was this patch tested?

Patch was tested manually.

Screen.Recording.2025-09-15.at.10.48.00.mov
Screen.Recording.2025-09-15.at.10.46.29.mov

@devabhishekpal
Copy link
Contributor Author

devabhishekpal commented Sep 15, 2025

@devmadhuu @ArafatKhan2198 @ivandika3 could you help with taking a look at this PR?

@devmadhuu devmadhuu self-requested a review September 15, 2025 09:55
devmadhuu
devmadhuu reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devabhishekpal for the patch. Changes largely looks good. Just few minor comments.

devmadhuu
devmadhuu approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devabhishekpal for the improving the patch. Changes LGTM +1

ArafatKhan2198
ArafatKhan2198 approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArafatKhan2198 ArafatKhan2198 mentioned this pull request Sep 17, 2025
Merged
@ArafatKhan2198 ArafatKhan2198 merged commit 428cb56 into apache:master Sep 17, 2025
35 checks passed
@devabhishekpal devabhishekpal deleted the HDDS-13542 branch October 7, 2025 06:38
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jan 12, 2026
@devabhishekpal
CDPD-88628. HDDS-13542. Separate out the API calls for Overview page (a…
5db296e 
…pache#9033)

(cherry picked from commit 428cb56)
Change-Id: I7b63ba50a0d61a52348de5b9c8cea4a816997d71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmadhuu devmadhuu devmadhuu approved these changes

@ArafatKhan2198 ArafatKhan2198 ArafatKhan2198 approved these changes

Assignees

No one assigned

Labels

recon UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devabhishekpal @devmadhuu @ArafatKhan2198 @adoroszlai