HDDS-13656. Fix aspectj settings for Java 11+

[symious]

What changes were proposed in this pull request?

The jdk version is set to 1.8 by aspect-maven-plugin, this ticket is fix the settings related to aspectj so that we can use user specified jdk for compilation.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13656

How was this patch tested?

MUST_HAVE=OzoneManagerStarter
javap -verbose "$(find . -type f -name ${MUST_HAVE}.class -print -quit)" 2>/dev/null | awk '/major version/{print $3; exit}'

The result should be based on "javac.version", thus not stick to 52.

[adoroszlai]

Thanks @symious for the patch.

[symious]

@adoroszlai Updated, PTAL.

[adoroszlai]

Thanks @symious for updating the patch, LGTM.

[errose28]

Thanks for fixing this @symious, I had been looking in this area well recently. Can you run a test matrix on your fork that takes each jdk version supported by our CI and runs it through the full test matrix to make sure there are no runtime issues? Although our current CI tests compile with multiple versions, the matrix is only run with the jdk21 build.

[errose28]

LGTM, @adoroszlai would you like to take another look?

[errose28]

Also as mentioned above, @symious it would be good to run the earlier jdk builds through the whole CI pipeline on your fork to make sure upgrade tests still run fine in those versions.

[adoroszlai]

Also set in global properties, so I guess we can remove the java9-or-later profile.

[symious]

Updated.

[symious]

Also as mentioned above, @symious it would be good to run the earlier jdk builds through the whole CI pipeline on your fork to make sure upgrade tests still run fine in those versions.

@errose28 Do you mean use earlier ozone-runner like this? https://github.com/symious/ozone/actions/runs/17606869330, https://github.com/symious/ozone/actions/runs/17606886128, but the runners are out of date.

[errose28]

Ah I didn't realize the runner only provided one jdk version. I think we should have enough coverage by just running the unit and integration tests in older jdk versions and skipping the acceptance tests.

[errose28]

With help from cursor I tried some modified workflows that ran the integration tests in a matrix based on jdk version and the produced code and test output looks correct to me. There's some unrelated race condition in our build which I was unable to fix. Some of the splits fail with messages like

Error:  Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.8.1:copy-dependencies (copy-jars) on project hdds-server-scm: Artifact 'org.apache.ozone:hdds-common:jar:2.1.0-SNAPSHOT:compile' has not been packaged yet (is a directory). When used on reactor artifact, copy should be executed after packaging: see MDEP-187. -> [Help 2]

Other than that most of the runs seem to be passing.

• This branch has changes to run the workflow with all jdk versions but built with bytecode 8
• This branch extends it to also build with bytecode in the same version as the jdk.

I'm not sure if it's worth trying to get these to run properly or we should call it good enough and merge this.

[adoroszlai]

Thanks @symious for the patch, @errose28 for review and testing.