HDDS-13592. Make InfoSubcommand validate all container IDs before proceeding #9001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2025 10:35
# Conflicts: # hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java
Gargi-jais11
force-pushed
the
HDDS-13592
branch
from
bc1af32 to
49dcd9e
Compare
sarvekshayr
reviewed
Sep 8, 2025
Contributor
There was a problem hiding this comment.
Thanks for working on this @Gargi-jais11
Overall the changes are looking good.
errose28
reviewed
Sep 12, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
One minor comment otherwise LGTM.
...p-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
Outdated
Show resolved
Hide resolved
errose28
approved these changes
Sep 15, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM, running the CI now.
Contributor
|
Thanks for the patch @Gargi-jais11 and the reviews @errose28 @sarvekshayr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-12078 added a method ContainerIDParameters#getValidatedIDs to validate and convert container IDs passed from the command line, and fail the command quickly if IDs with invalid syntax are used. This was added for ozone admin container reconcile but should be used for ozone admin container info as well.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13592
How was this patch tested?
Added robot test and new unit tests to
TestInfoSubCommand.Below is the output after local check on docker cluster.