HDDS-2366. Remove ozone.enabled as a flag and config item. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
Overall LGTM. This property needs to be removed from docker-config and few documentation files.
adoroszlai
reviewed
Oct 26, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
This integration test failure seems to be related:
elek
changed the title
bharatviswa504
approved these changes
Oct 30, 2019
Contributor
There was a problem hiding this comment.
+1 LGTM.
@adoroszlai Now tests are passing. If you are fine with changes, I will go ahead and commit it.
I will wait till EOD if no more comments will commit the changes.
dineshchitlangia
approved these changes
Oct 30, 2019
Contributor
There was a problem hiding this comment.
+1 LGTM. Thank you @swagle for covering all edge cases and tools!
Integration failure is unrelated.
Contributor
|
Thanks for the reviews and patch. Merged to the master. |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
apache#5809) (apache#90) Change-Id: Ieb7f6d67ca255270636580d97fb78d960b40b326 Co-authored-by: Doroszlai, Attila <[email protected]>
vtutrinov
pushed a commit
to vtutrinov/ozone
that referenced
this pull request
Jul 15, 2025
Merge in SDP/component-ozone from SDPOZN-707-ozone-1.4-log4j-upgrade to sdp-ozone-1.4 * commit '258bef5769bcff132f583f08ba5459bbbdaa072a': HDDS-10898. Validate OZONE_CONF_DIR by presence of ozone-site.xml (apache#6713) [SDPOZN-707] log4j2-slf4j-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed all checks for ozone.enabled and configuration items.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2366
How was this patch tested?
Verified mvn install and checkstyle goals succeed.