-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-13612. Track SST file ranges in sst file metadata #8981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4d7e2e9
HDDS-13612. Track Sst file ranges in sst file metadata
swamirishi ffcd6d4
HDDS-13612. Track Sst file ranges in sst file metadata
swamirishi f0039d2
Merge remote-tracking branch 'apache/master' into HEAD
swamirishi e07d450
HDDS-13612. Fix dependency
swamirishi 0bced59
HDDS-13612. Fix Test case
swamirishi f643193
HDDS-13612. Add javadoc
swamirishi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
.../rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/SstFileInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ozone.compaction.log; | ||
|
|
||
| import java.util.Objects; | ||
| import org.apache.hadoop.hdds.StringUtils; | ||
| import org.apache.hadoop.hdds.utils.db.CopyObject; | ||
| import org.rocksdb.LiveFileMetaData; | ||
|
|
||
| /** | ||
| * Dao to keep SST file information in the compaction log. | ||
| */ | ||
| public class SstFileInfo implements CopyObject<SstFileInfo> { | ||
| private final String fileName; | ||
| private final String startKey; | ||
| private final String endKey; | ||
| private final String columnFamily; | ||
|
|
||
| public SstFileInfo(String fileName, String startRange, String endRange, String columnFamily) { | ||
| this.fileName = fileName; | ||
| this.startKey = startRange; | ||
| this.endKey = endRange; | ||
| this.columnFamily = columnFamily; | ||
| } | ||
|
|
||
| public SstFileInfo(LiveFileMetaData fileMetaData) { | ||
| this(fileMetaData.fileName(), StringUtils.bytes2String(fileMetaData.smallestKey()), | ||
| StringUtils.bytes2String(fileMetaData.largestKey()), | ||
| StringUtils.bytes2String(fileMetaData.columnFamilyName())); | ||
| } | ||
|
|
||
| public String getFileName() { | ||
| return fileName; | ||
| } | ||
|
|
||
| public String getStartKey() { | ||
| return startKey; | ||
| } | ||
|
|
||
| public String getEndKey() { | ||
| return endKey; | ||
| } | ||
|
|
||
| public String getColumnFamily() { | ||
| return columnFamily; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return String.format("fileName: '%s', startKey: '%s', endKey: '%s'," + | ||
| " columnFamily: '%s'", fileName, startKey, endKey, columnFamily); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (!(o instanceof SstFileInfo)) { | ||
| return false; | ||
| } | ||
|
|
||
| SstFileInfo that = (SstFileInfo) o; | ||
| return Objects.equals(fileName, that.fileName) && | ||
| Objects.equals(startKey, that.startKey) && | ||
| Objects.equals(endKey, that.endKey) && | ||
| Objects.equals(columnFamily, that.columnFamily); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(fileName, startKey, endKey, columnFamily); | ||
| } | ||
|
|
||
| @Override | ||
| public SstFileInfo copyObject() { | ||
| return new SstFileInfo(fileName, startKey, endKey, columnFamily); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The cast to CompactionFileInfo is unsafe since the type check was performed for CompactionFileInfo. However, consider storing the cast result in a variable for better readability:
CompactionFileInfo other = (CompactionFileInfo) o; return super.equals(o) && pruned == other.pruned;