HDDS-13510. Add latency metrics for key creation operation#8896
Merged
Tejaskriya merged 4 commits intoapache:masterfrom Sep 15, 2025
Merged
HDDS-13510. Add latency metrics for key creation operation#8896Tejaskriya merged 4 commits intoapache:masterfrom
Tejaskriya merged 4 commits intoapache:masterfrom
Conversation
Tejaskriya
reviewed
Aug 6, 2025
Contributor
Tejaskriya
left a comment
There was a problem hiding this comment.
Thanks for working on this @sreejasahithi , please find some comments below
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequestWithFSO.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequestWithFSO.java
Outdated
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
Outdated
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
Outdated
Show resolved
Hide resolved
Tejaskriya
approved these changes
Aug 11, 2025
Contributor
Tejaskriya
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating!
sarvekshayr
reviewed
Aug 25, 2025
Contributor
sarvekshayr
left a comment
There was a problem hiding this comment.
@sreejasahithi, please take a look at the comment below -
| omBucketInfo.copyObject(), volumeId); | ||
|
|
||
| result = Result.SUCCESS; | ||
| long endNanosCreateKeySuccessLatencyNs = Time.monotonicNowNanos(); |
Contributor
There was a problem hiding this comment.
Rename endNanosCreateKeySuccessLatencyNs in both places to createKeyEndTime, capture the time in the finally block and update the latency metrics based on result.
finally {
long createKeyEndTime = Time.monotonicNowNanos();
long latency = createKeyEndTime - createKeyStartTime;
if (result == Result.SUCCESS) {
perfMetrics.addCreateKeySuccessLatencyNs(latency);
} else {
perfMetrics.addCreateKeyFailureLatencyNs(latency);
}
Contributor
|
Thanks @sreejasahithi and @sarvekshayr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of performance improvements, new metrics to capture latency for major sub-operation in key creation are introduced. This will help in understanding where more time is spent during key creation and make it easier to troubleshoot slowness.
What is the link to the Apache JIRA
HDDS-13510
How was this patch tested?
CI: https://github.com/sreejasahithi/ozone/actions/runs/16717200562
Sample outputs of the metrics over Prometheus for a total of 2000 keys created.