Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Aug 1, 2025

What changes were proposed in this pull request?

Fix intermittent failure in TestNSSummaryMemoryLeak:

Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 50.48 s <<< FAILURE! -- in org.apache.hadoop.ozone.recon.TestNSSummaryMemoryLeak
org.apache.hadoop.ozone.recon.TestNSSummaryMemoryLeak.testMemoryLeakWithLargeStructure -- Time elapsed: 14.14 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
...
  at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
  at org.apache.hadoop.ozone.recon.TestNSSummaryMemoryLeak.testMemoryLeakWithLargeStructure(TestNSSummaryMemoryLeak.java:321)

https://issues.apache.org/jira/browse/HDDS-13514

How was this patch tested?

Before: 6/100 runs failed
https://github.com/adoroszlai/ozone/actions/runs/16676152386

After: 100/100 runs passed
https://github.com/adoroszlai/ozone/actions/runs/16676072218
https://github.com/adoroszlai/ozone/actions/runs/16679377827

@adoroszlai adoroszlai self-assigned this Aug 1, 2025
@adoroszlai adoroszlai added the test label Aug 1, 2025
@adoroszlai adoroszlai requested a review from devmadhuu August 1, 2025 16:03
@adoroszlai
Copy link
Contributor Author

@devmadhuu please take a look

Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for fixing the intermittent failure. Changes LGTM +1

@adoroszlai adoroszlai merged commit 0fd649e into apache:master Aug 4, 2025
81 of 83 checks passed
@adoroszlai adoroszlai deleted the HDDS-13514 branch August 4, 2025 11:32
@adoroszlai
Copy link
Contributor Author

Thanks @devmadhuu for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Aug 12, 2025
* master: (55 commits)
  HDDS-13525. Rename configuration property to ozone.om.compaction.service.enabled (apache#8928)
  HDDS-13519. Reconciliation should continue if a peer datanode is unreachable (apache#8908)
  HDDS-13566. Fix incorrect authorizer class in ACL documentation (apache#8931)
  HDDS-13084. Trigger on-demand container scan when a container moves from open to unhealthy. (apache#8904)
  HDDS-13432. Accelerating Namespace Usage Calculation in Recon using - Materialised Approach (apache#8797)
  HDDS-13557. Bump jline to 3.30.5 (apache#8920)
  HDDS-13556. Bump assertj-core to 3.27.4 (apache#8919)
  HDDS-13543. [Docs] Design doc for OM bootstrapping process with snapshots. (apache#8900)
  HDDS-13541. Bump sonar-maven-plugin to 5.1.0.4751 (apache#8911)
  HDDS-13101. Remove duplicate information in datanode list output (apache#8523)
  HDDS-13528. Handle null paths when the NSSummary is initializing (apache#8901)
  HDDS-12990. (addendum) Generate tree from metadata when it does not exist during getContainerChecksumInfo call (apache#8881)
  HDDS-13086. Block duplicate reconciliation requests for the same container and datanode within the datanode. (apache#8905)
  HDDS-12990. Generate tree from metadata when it doesn't exist during getContainerChecksumInfo call (apache#8881)
  HDDS-12824. Optimize container checksum read during datanode startup (apache#8604)
  HDDS-13522. Rename axisLabel for No. of delete request received (apache#8879)
  HDDS-12196. Document ozone repair cli (apache#8849)
  HDDS-13514. Intermittent failure in TestNSSummaryMemoryLeak (apache#8889)
  HDDS-13423. Log reason for triggering on-demand container scan (apache#8854)
  HDDS-13466. Disable flaky TestOmSnapshotFsoWithNativeLibWithLinkedBuckets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants