HDDS-13227. Integration test for inode based bootstrap flow. #8884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Jul 31, 2025
Comment on lines
+248
to
+256
| boolean obtainedFilesUnderMaxLimit = totalSize < maxFileSizeLimit; | ||
| if (!includeSnapshots) { | ||
| // If includeSnapshotData flag is set to false , it always sends all data | ||
| // in one batch and doesn't respect the max size config. This is how Recon | ||
| // uses it today. | ||
| assertFalse(obtainedFilesUnderMaxLimit); | ||
| } else { | ||
| assertTrue(obtainedFilesUnderMaxLimit); | ||
| } |
Contributor
There was a problem hiding this comment.
Can simplify as:
Suggested change
| boolean obtainedFilesUnderMaxLimit = totalSize < maxFileSizeLimit; | |
| if (!includeSnapshots) { | |
| // If includeSnapshotData flag is set to false , it always sends all data | |
| // in one batch and doesn't respect the max size config. This is how Recon | |
| // uses it today. | |
| assertFalse(obtainedFilesUnderMaxLimit); | |
| } else { | |
| assertTrue(obtainedFilesUnderMaxLimit); | |
| } | |
| // If includeSnapshotData flag is set to false , it always sends all data | |
| // in one batch and doesn't respect the max size config. This is how Recon | |
| // uses it today. | |
| assertEquals(includeSnapshots, totalSize < maxFileSizeLimit); |
jojochuang
approved these changes
Jul 31, 2025
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
looks good to me. One small suggestion but it doesn't affect correctness.
Will merge later today.
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
Nov 19, 2025
…pache#8884)" This reverts commit e515f3a. Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java Change-Id: I5bbcc209483aca0343b713fe8dcc77dd0b3e7508
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
Nov 20, 2025
…pache#8884)" This reverts commit e515f3a. Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java Change-Id: I5bbcc209483aca0343b713fe8dcc77dd0b3e7508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Existing tests in TestOMDBCheckpointServletInodeBasedXfer and TestOMRatisSnapshots cover this flow too.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13227