HDDS-13407. Fix intermittent failure in TestOnDemandContainerDataScanner#testUnhealthyContainersDetected. #8876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jul 29, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @errose28 for the patch, LGTM.
Contributor
Author
|
Thanks @adoroszlai for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jul 31, 2025
…ner#testUnhealthyContainersDetected. (apache#8876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-12849 made the on-demand scanner non-static. This means we do not need to wait for it to be initialized before scanning, so the assert that was failing here was no longer valid. The failure shows up intermittently because on-demand scanning is async. In most cases the scan would not have completed by the time the assert ran, so there were still no interactions with the mock.
What is the link to the Apache JIRA
HDDS-13407
How was this patch tested?
Previously it was noted the test failed about 1/10 times in CI. 200 runs of this test with this change passed here.