HDDS-12710. UI changes for fixing counts and container pagination. #8862
Conversation
Change-Id: I3aee1631a262e2d941dbbbcddcb7a7c5e286d33a
|
@devmadhuu @devabhishekpal can you please take a look |
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
@ArafatKhan2198 Thanks for the patch. Looks like your PR needs to be rebased against #8796 because These same changes appear in #8796 , may need rebase of code ?
Also please check the screenshot in PR description. This was fixed as part of #8074 where it column is still showing the number of keys, rather they are number of blocks.
...one/recon-codegen/src/main/java/org/apache/ozone/recon/schema/ContainerSchemaDefinition.java
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconConstants.java
Show resolved
Hide resolved
...ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java
Show resolved
Hide resolved
...recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainersResponse.java
Show resolved
Hide resolved
...on/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHealthSchemaManager.java
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
...in/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx
Outdated
Show resolved
Hide resolved
devabhishekpal
left a comment
devabhishekpal
left a comment
There was a problem hiding this comment.
Thanks for the changes @ArafatKhan2198,
These look good to me.
Currently there is a limitation on AntD which doesn't play well with the backend pagination, we might need to think of alternatives for this pagination which would work better.
Also it would be good to raise a ticket to track global search as the UI search currently would be searching only on the data it fetched which is the page size that is selected.
Apart from these the patch is overall good.
Thanks for working on this.
priyeshkaratha
left a comment
priyeshkaratha
left a comment
There was a problem hiding this comment.
Thanks for the patch @ArafatKhan2198 .
LGTM. added one minor comment.
| > | ||
| <InfoCircleOutlined className='icon-small' /> | ||
| </Tooltip> | ||
| <span className='pl-5'> |
There was a problem hiding this comment.
can you correct line indentation.
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @ArafatKhan2198 for the patch, the changes LGTM!
6 participants
What changes were proposed in this pull request?
What changes were proposed in this pull request?
UI changes for fixing container pagination and showing counts.
Backend changes - #8796
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12710
How was this patch tested?
Tested on UI -