Skip to content

Conversation

@sarvekshayr
Copy link
Contributor

@sarvekshayr sarvekshayr commented Jul 24, 2025

What changes were proposed in this pull request?

The intermittent failure was caused by sst files not being generated immediately after creating a large number of keys.

This is resolved by restarting the OM container after key creation, which forces a flush and triggers sst file generation. Additionally, reduced the number of keys to be created, as the OM restart ensures sst files are created even with fewer keys.

Testing OM DB Size Reduction After Compaction                         | FAIL |
'' cannot be converted to an integer: ValueError: invalid literal for int() with base 10: ''

What is the link to the Apache JIRA

HDDS-13499

How was this patch tested?

CI: https://github.com/sarvekshayr/ozone/actions/runs/16491234553/job/46627566391#step:13:467

repeat-acceptance-test CI: https://github.com/sarvekshayr/ozone/actions/runs/16496011518

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @sarvekshayr! The changes are looking good to me, do you think we should do fork runs for this suite (like at #8771)? How often did it occurred on the master CI?

@sarvekshayr
Copy link
Contributor Author

sarvekshayr commented Jul 24, 2025

do you think we should do fork runs for this suite (like at #8771)? How often did it occurred on the master CI?

Tested it using repeat-acceptance-test. All the splits have passed.
repeat-acceptance-test CI: https://github.com/sarvekshayr/ozone/actions/runs/16496011518

@dombizita dombizita added the tools Tools that helps with debugging label Jul 24, 2025
@dombizita dombizita merged commit 4d9deb7 into apache:master Jul 24, 2025
29 checks passed
@dombizita
Copy link
Contributor

Thanks for fixing this quickly @sarvekshayr!

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Tools that helps with debugging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants