HDDS-13500. Transfer Non SST Files in the last batch of the tarball transfer. #8857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Jul 25, 2025
Contributor
There was a problem hiding this comment.
I guess we want to add a few lines of explanation in the writeDBToArchive or writeDbDataToStream method, that as an optimization, onlySstFile is expected to be false only at the last batch iteration. Otherwise several months from now I won't remember a thing.
...n-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Jul 26, 2025
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Apart from these cosmetic issues this PR almost ready to go
...n-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java
Outdated
Show resolved
Hide resolved
added 2 commits
July 30, 2025 00:26
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jojochuang
approved these changes
Jul 30, 2025
Contributor
Author
|
Thanks @jojochuang for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jul 31, 2025
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
Nov 19, 2025
…arball transfer. (apache#8857)" This reverts commit 2870126. Conflicts: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java Change-Id: Ib9141efa7e55b0f71520da8e16d32f5cd9b63331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the current impl, all file types in the DB are transferred in every batch and subsequent requests exclude the already tranferred files. If the mod time for a file changes they would be resent in the next batch which means that a file like LOG would be transferred in every batch.
To avoid this we can send non-sst files only in the last batch and send in the .sst files in the earlier transfers.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13500
How was this patch tested?
Unit tests