HDDS-12454. Create new module for multitenancy with Ranger#8799
HDDS-12454. Create new module for multitenancy with Ranger#8799adoroszlai merged 5 commits intoapache:masterfrom
Conversation
|
@smengcl can you please take a look? |
|
Sorry for being very late to review this one. This flew under my radar. Let me take a look. |
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the Ranger-specific multitenancy implementation from the Ozone Manager module into a new dedicated module ozone-multitenancy-ranger. This separation allows the Ranger dependencies to be loaded at runtime rather than being directly bundled with the core Ozone Manager.
- Create new
ozone-multitenancy-rangermodule with Ranger dependencies - Remove Ranger dependencies from
ozone-managermodule - Update dependency management and exclusions across affected modules
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Add dependency management for new multitenancy-ranger module |
| hadoop-ozone/pom.xml | Include new multitenancy-ranger module in build |
| hadoop-ozone/ozone-manager/pom.xml | Remove Ranger dependencies that moved to new module |
| hadoop-ozone/multitenancy-ranger/pom.xml | New module POM with Ranger dependencies and exclusions |
| hadoop-ozone/multitenancy-ranger/src/main/java/org/apache/hadoop/ozone/om/multitenant/RangerClientMultiTenantAccessController.java | Replace Guava Preconditions with Java Objects for null checks |
| hadoop-ozone/multitenancy-ranger/src/main/java/org/apache/hadoop/ozone/om/multitenant/package-info.java | Add package documentation for new module |
| hadoop-ozone/multitenancy-ranger/dev-support/findbugsExcludeFile.xml | SpotBugs configuration for new module |
| hadoop-ozone/recon/pom.xml | Remove Jersey exclusions no longer needed |
| hadoop-ozone/integration-test/pom.xml | Add test dependency on new multitenancy-ranger module |
| hadoop-ozone/integration-test-recon/pom.xml | Remove Jersey exclusions no longer needed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ain/java/org/apache/hadoop/ozone/om/multitenant/RangerClientMultiTenantAccessController.java
Show resolved
Hide resolved
smengcl
left a comment
There was a problem hiding this comment.
lgtm. Thanks @adoroszlai for the refactoring effort!
|
Thanks @smengcl for the review and merging |
What changes were proposed in this pull request?
Move Ranger-specific multitenancy implementation out of Ozone Manager to a new module, which is added to OM's classpath at runtime.
https://issues.apache.org/jira/browse/HDDS-12454
How was this patch tested?
Existing multi-tenancy tests.
CI:
https://github.com/adoroszlai/ozone/actions/runs/16260068242