Skip to content

HDDS-12454. Create new module for multitenancy with Ranger#8799

Merged
adoroszlai merged 5 commits intoapache:masterfrom
adoroszlai:HDDS-12454
Sep 17, 2025
Merged

HDDS-12454. Create new module for multitenancy with Ranger#8799
adoroszlai merged 5 commits intoapache:masterfrom
adoroszlai:HDDS-12454

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Move Ranger-specific multitenancy implementation out of Ozone Manager to a new module, which is added to OM's classpath at runtime.

https://issues.apache.org/jira/browse/HDDS-12454

How was this patch tested?

Existing multi-tenancy tests.

CI:
https://github.com/adoroszlai/ozone/actions/runs/16260068242

@adoroszlai adoroszlai self-assigned this Jul 14, 2025
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Jul 14, 2025
@adoroszlai adoroszlai requested a review from smengcl July 14, 2025 18:13
@adoroszlai
Copy link
Contributor Author

@smengcl can you please take a look?

@smengcl
Copy link
Contributor

smengcl commented Sep 16, 2025

Sorry for being very late to review this one. This flew under my radar. Let me take a look.

@smengcl smengcl requested a review from Copilot September 16, 2025 21:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts the Ranger-specific multitenancy implementation from the Ozone Manager module into a new dedicated module ozone-multitenancy-ranger. This separation allows the Ranger dependencies to be loaded at runtime rather than being directly bundled with the core Ozone Manager.

  • Create new ozone-multitenancy-ranger module with Ranger dependencies
  • Remove Ranger dependencies from ozone-manager module
  • Update dependency management and exclusions across affected modules

Reviewed Changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Add dependency management for new multitenancy-ranger module
hadoop-ozone/pom.xml Include new multitenancy-ranger module in build
hadoop-ozone/ozone-manager/pom.xml Remove Ranger dependencies that moved to new module
hadoop-ozone/multitenancy-ranger/pom.xml New module POM with Ranger dependencies and exclusions
hadoop-ozone/multitenancy-ranger/src/main/java/org/apache/hadoop/ozone/om/multitenant/RangerClientMultiTenantAccessController.java Replace Guava Preconditions with Java Objects for null checks
hadoop-ozone/multitenancy-ranger/src/main/java/org/apache/hadoop/ozone/om/multitenant/package-info.java Add package documentation for new module
hadoop-ozone/multitenancy-ranger/dev-support/findbugsExcludeFile.xml SpotBugs configuration for new module
hadoop-ozone/recon/pom.xml Remove Jersey exclusions no longer needed
hadoop-ozone/integration-test/pom.xml Add test dependency on new multitenancy-ranger module
hadoop-ozone/integration-test-recon/pom.xml Remove Jersey exclusions no longer needed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @adoroszlai for the refactoring effort!

@adoroszlai adoroszlai merged commit dec5fc9 into apache:master Sep 17, 2025
43 checks passed
@adoroszlai adoroszlai deleted the HDDS-12454 branch September 17, 2025 05:47
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review and merging master into the PR. +1 for triggering CI on outdated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull request that modifies the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants