HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush #8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h write Change-Id: I65444c0155b471c31ea1283d563d9a948f5e4005
…impact Change-Id: I3b34e1bb6ca7587243f6eef176c396ca0132dbc3
Change-Id: Iab23d0b1316eac9c376fd06226d234b97e908b4f
Change-Id: I74fed5aebb5c0588cbf97f70a0f9acf94edfa87c
… rocksdb Change-Id: Ic123641dcb78c53917d9db922cdaace9649d12b0
…Flush Change-Id: I6effb3bd53ad0c29884d2c32d900a17ebb501243
Contributor
|
Please wait for the other PR (#8778) to be merged before opening the dependent one. PRs should not be sitting in the queue. |
swamirishi
commented
Nov 10, 2025
Comment on lines
+348
to
+349
| omMetadataManager.getFlushedTransactionsTable().deleteRangeWithBatch(batchOperation, 0L, | ||
| Math.max(lastTransaction.getIndex() - maxFlushedTransactionGap, 0L)); |
Contributor
Author
There was a problem hiding this comment.
This can be used in event notification design as well.
swamirishi
commented
Dec 23, 2025
| () -> response.checkAndUpdateDB(omMetadataManager, batchOperation)); | ||
| addToBatchWithTrace(omResponse, () -> { | ||
| response.checkAndUpdateDB(omMetadataManager, batchOperation); | ||
| omMetadataManager.getFlushedTransactionsTable().putWithBatch(batchOperation, entry.termIndex.getIndex(), |
Contributor
Author
There was a problem hiding this comment.
flush as part of double buffer batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of the OM Double Buffer flush, an entry corresponding to each transaction flushed should be added to the flushedTransactionsTable in OM rocksdb.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13418
How was this patch tested?
Additional unit test to be added.