Skip to content

HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig #8760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryangupta1998 merged 2 commits into from
Jul 14, 2025
Merged

HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig #8760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5060929
HDDS-13387. OMSnapshotCreateRequest logs invalid warning about Defaul…
Jul 7, 2025
f3cbd7f
Removed misleading comments
Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...er/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,14 +339,8 @@ private long estimateBucketDataSize(OmBucketInfo bucketInfo) {
DefaultReplicationConfig defRC = bucketInfo.getDefaultReplicationConfig();
final ReplicationConfig rc;
if (defRC == null) {
// Note: A lot of tests are not setting bucket DefaultReplicationConfig,
// sometimes intentionally.
// Fall back to config default and print warning level log.
// Fall back to config default.
rc = ReplicationConfig.getDefault(new OzoneConfiguration());
LOG.warn("DefaultReplicationConfig is not correctly set in " +
"OmBucketInfo for volume '{}' bucket '{}'. " +
"Falling back to config default '{}'",
bucketInfo.getVolumeName(), bucketInfo.getBucketName(), rc);
} else {
rc = defRC.getReplicationConfig();
}
Expand Down