Skip to content

HDDS-13248. Remove ozone debug replicas verify option --output-dir #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 3 commits into from
Jun 13, 2025
+3 −8
Merged

HDDS-13248. Remove ozone debug replicas verify option --output-dir #8612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07dac02
HDDS-13248. Make --output-dir optional for replicas verify
Tejaskriya Jun 12, 2025
d9d0e32
remove output-dir option
Tejaskriya Jun 13, 2025
80b31b8
remove from ozone-debug.robot
Tejaskriya Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Write keys

*** Test Cases ***
Test ozone debug replicas verify checksums
${output} = Execute ozone debug replicas verify --checksums --block-existence --container-state o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE} --output-dir ${TEMP_DIR}
${output} = Execute ozone debug replicas verify --checksums --block-existence --container-state o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
${json} = Evaluate json.loads('''${output}''') json

# 'keys' array should be empty if all keys and their replicas passed checksum verification
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ${OM_SERVICE_ID} %{OM_SERVICE_ID}

*** Keywords ***
Execute replicas verify checksums CLI tool
Execute ozone debug -Dozone.network.topology.aware.read=true replicas verify --checksums --output-dir ${TEMP_DIR} o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
Execute ozone debug -Dozone.network.topology.aware.read=true replicas verify --checksums o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
${directory} = Execute ls -d ${TEMP_DIR}/${VOLUME}_${BUCKET}_${TESTFILE}_*/ | tail -n 1
Directory Should Exist ${directory}
File Should Exist ${directory}/${TESTFILE}_manifest
Expand Down
2 changes: 1 addition & 1 deletion ...one/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugShell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public void testReplicasVerifyCmd(boolean isEcKey) throws Exception {
getSetConfStringFromConf(OMConfigKeys.OZONE_OM_ADDRESS_KEY),
getSetConfStringFromConf(ScmConfigKeys.OZONE_SCM_CLIENT_ADDRESS_KEY),
"replicas", "verify", "--checksums", "--block-existence", "--container-state", fullKeyPath,
"--output-dir", "/"//, "--all-results"
//, "--all-results"
};

int exitCode = ozoneDebugShell.execute(args);
Expand Down
5 changes: 0 additions & 5 deletions hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ public class ReplicasVerify extends Handler {
description = Shell.OZONE_URI_DESCRIPTION)
private String uri;

@CommandLine.Option(names = {"-o", "--output-dir"},
description = "Destination directory to save the generated output.",
required = true)
private String outputDir;

@CommandLine.Option(names = {"--all-results"},
description = "Print results for all passing and failing keys")
private boolean allResults;
Expand Down
Loading