Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"__inputs": [
{
"name": "DS_PROMETHEUS",
"label": "prometheus",
"description": "",
"type": "datasource",
Expand Down Expand Up @@ -35,8 +34,7 @@
{
"builtIn": 1,
"datasource": {
"type": "grafana",
"uid": "-- Grafana --"
"type": "grafana"
},
"enable": true,
"hide": true,
Expand All @@ -54,8 +52,7 @@
"panels": [
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
Copy link
Contributor

@smengcl smengcl Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like DS_PROMETHEUS is supposed to be taken as input?

"__inputs": [
{
"name": "DS_PROMETHEUS",
"label": "prometheus",
"description": "",
"type": "datasource",
"pluginId": "prometheus",
"pluginName": "Prometheus"
}
],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have no idea which field would be taken as uid

Copy link
Member Author

@peterxcli peterxcli Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least the web doesnt resolve or substitute it
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DS_prometheus can be removed from here too. In Ozone - OMComittedIndexMetrics.json, Ozone - Ozone Manager RocksDB.json
(Refering from Ozone - ReadKey Metrics.json)
@peterxcli @smengcl does that sound fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Removed. Thanks for checking this!

"type": "prometheus"
},
"fieldConfig": {
"defaults": {
Expand Down Expand Up @@ -133,8 +130,7 @@
"targets": [
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
"type": "prometheus"
},
"editorMode": "code",
"exemplar": false,
Expand Down
Loading