HDDS-12927. metrics and log to indicate datanode crossing disk limits

[sumitagrawl]

What changes were proposed in this pull request?

metrics and logs are added during volume check for below cases:

1. volume space is insuffiecient, i.e. lesser than min.free.space OR sum(min.free.space + committed bytes)
2. volume reserved usages consumption is more than configured value

Metrics added:

• availableSpaceInsufficient
• reservedCrossesLimit

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12927

How was this patch tested?

• Unit test case added

Sample Logs as generated:

WARN  volume.HddsVolume (HddsVolume.java:checkVolumeUsages(362)) - Volume /var/folders/ll/3dtzmk1j4693_v1x7_msvfqc0000gn/T/junit-1914764595138761718/hdds has insufficient space for on-going container write operation. Committed: 100, Available: 100, Free space to spare: 10

WARN  volume.VolumeUsage (VolumeUsage.java:isReservedUsagesInRange(246)) - Reserved usages 100 is higher than actual allocated reserved space 200.
WARN  volume.HddsVolume (HddsVolume.java:checkVolumeUsages(371)) - Volume /var/folders/ll/3dtzmk1j4693_v1x7_msvfqc0000gn/T/junit-1914764595138761718/hdds reserved usages is higher than actual allocated reserved space.

[Copilot]

Pull Request Overview

Adds logging and metrics to detect when a DataNode volume crosses disk usage thresholds (insufficient free space or reserved usage limit).

• Introduces checkVolumeUsages() in HddsVolume to emit warnings and update new metrics.
• Adds two new gauges (availableSpaceInsufficient, reservedCrossesLimit) in VolumeInfoMetrics with setters and getters.
• Implements VolumeUsage.isReservedUsagesInRange() and updates tests in TestHddsVolume.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestHddsVolume.java	Adds testVolumeUsagesMetrics to verify new space and reserved-usage metrics.
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java	Adds isReservedUsagesInRange() to log and flag when reserved usage exceeds the configured limit.
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeInfoMetrics.java	Defines two new MutableGaugeInt fields and corresponding setter/getter methods for the new metrics.
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java	Implements checkVolumeUsages() to evaluate space thresholds and update the new metrics accordingly.

Comments suppressed due to low confidence (2)

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:356

• [nitpick] The variable name getFreeSpaceToSpare shadows the method of the same name and can be confusing. Consider renaming the variable to freeSpaceToSpare for clarity.

long getFreeSpaceToSpare = getFreeSpaceToSpare(currentUsage.getCapacity());

hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestHddsVolume.java:556

• Consider adding a test assertion to verify that reservedCrossesLimit resets to 0 when reserved usage falls back within limits, covering the clearing path of this metric.

assertEquals(1, volume.getVolumeInfoStats().getReservedCrossesLimit());

[siddhantsangwan]

Just one minor comment, otherwise looks good.

[siddhantsangwan]

LGTM, pending green CI.