Skip to content

Conversation

@chungen0126
Copy link
Contributor

@chungen0126 chungen0126 commented Jun 5, 2025

What changes were proposed in this pull request?

See the Maven error message:

Error:  Failed to execute goal com.coderplus.maven.plugins:copy-rename-maven-plugin:1.0.1:rename (rename-generated-config) on project ozone-manager: sourceFile /home/runner/work/ozone/ozone/hadoop-ozone/ozone-manager/target/classes/ozone-default-generated.xml does not exist -> [Help 1]
843Error:  
844Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
845Error:  Re-run Maven using the -X switch to enable full debug logging.
846Error:  
847Error:  For more information about the errors and possible solutions, please read the following articles:
848Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException 

The ozone-default-generated.xml file might be missing during a second mvn install.
The root cause is that some sub-modules rename the file, leading to errors when the source file no longer existed after the first install.
To resolve this, generate the XML file using each sub-module’s artifactId instead of renaming.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13179

How was this patch tested?

CI: https://github.com/chungen0126/ozone/actions/runs/15476120160

@chungen0126 chungen0126 closed this Jun 5, 2025
@adoroszlai
Copy link
Contributor

@chungen0126 flaky-test-check was fixed in HDDS-13169, and other CI checks run in clean environment. However, the same problem can affect checks when run locally. I think your change makes sense, so we should not abandon it. (We may want to omit ozone-default-generated.xml from the build output's jars, though.)

@chungen0126
Copy link
Contributor Author

@chungen0126 flaky-test-check was fixed in HDDS-13169, and other CI checks run in clean environment. However, the same problem can affect checks when run locally. I think your change makes sense, so we should not abandon it. (We may want to omit ozone-default-generated.xml from the build output's jars, though.)

Thanks @adoroszlai for the clarification! That makes sense. I’ve updated the patch. Please take a look when you are available.

@chungen0126
Copy link
Contributor Author

chungen0126 commented Jun 5, 2025

I created another one #8569 because I force-pushed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants