Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ public final class OzoneConfigKeys {

public static final String FS_TRASH_CLASSNAME = "fs.trash.classname";
public static final String FS_TRASH_CLASSNAME_DEFAULT =
"org.apache.hadoop.ozone.om.TrashPolicyOzone";
"org.apache.hadoop.fs.ozone.OzoneTrashPolicy";

public static final String
OZONE_OM_SNAPSHOT_COMPACTION_DAG_MAX_TIME_ALLOWED =
Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/common/src/main/resources/ozone-default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2789,7 +2789,7 @@

<property>
<name>fs.trash.classname</name>
<value>org.apache.hadoop.ozone.om.TrashPolicyOzone</value>
<value>org.apache.hadoop.fs.ozone.OzoneTrashPolicy</value>
<tag>OZONE, OZONEFS, CLIENT</tag>
<description>
Trash Policy to be used.
Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/docs/content/interface/Ofs.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ In order to enable trash in Ozone, Please add these configs to core-site.xml
</property>
<property>
<name>fs.trash.classname</name>
<value>org.apache.hadoop.ozone.om.TrashPolicyOzone</value>
<value>org.apache.hadoop.fs.ozone.OzoneTrashPolicy</value>
</property>
{{< /highlight >}}

Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/docs/content/interface/Ofs.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ $ ozone fs -put ./NOTICE.txt ofs://om/tmp/key1
</property>
<property>
<name>fs.trash.classname</name>
<value>org.apache.hadoop.ozone.om.TrashPolicyOzone</value>
<value>org.apache.hadoop.fs.ozone.OzoneTrashPolicy</value>
</property>
{{< /highlight >}}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@
import org.apache.hadoop.ozone.om.OMMetrics;
import org.apache.hadoop.ozone.om.OmConfig;
import org.apache.hadoop.ozone.om.OzonePrefixPathImpl;
import org.apache.hadoop.ozone.om.TrashPolicyOzone;
import org.apache.hadoop.ozone.om.exceptions.OMException;
import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.apache.hadoop.ozone.om.helpers.OmKeyArgs;
Expand Down Expand Up @@ -1685,7 +1684,7 @@ public void testTrash() throws Exception {
ContractTestUtils.touch(fs, path);
assertTrue(trash.getConf().getClass(
"fs.trash.classname", TrashPolicy.class).
isAssignableFrom(TrashPolicyOzone.class));
isAssignableFrom(OzoneTrashPolicy.class));
assertEquals(TRASH_INTERVAL, trash.getConf().
getFloat(OMConfigKeys.OZONE_FS_TRASH_INTERVAL_KEY, 0), 0);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
import org.apache.hadoop.ozone.om.OMConfigKeys;
import org.apache.hadoop.ozone.om.OMMetrics;
import org.apache.hadoop.ozone.om.OmConfig;
import org.apache.hadoop.ozone.om.TrashPolicyOzone;
import org.apache.hadoop.ozone.om.exceptions.OMException;
import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.apache.hadoop.ozone.om.helpers.QuotaUtil;
Expand Down Expand Up @@ -1869,7 +1868,7 @@ void testTrash() throws Exception {

assertTrue(trash.getConf().getClass(
"fs.trash.classname", TrashPolicy.class).
isAssignableFrom(TrashPolicyOzone.class));
isAssignableFrom(OzoneTrashPolicy.class));

long prevNumTrashDeletes = getOMMetrics().getNumTrashDeletes();
long prevNumTrashFileDeletes = getOMMetrics().getNumTrashFilesDeletes();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.fs.TrashPolicy;
import org.apache.hadoop.fs.ozone.OzoneFsShell;
import org.apache.hadoop.fs.ozone.OzoneTrashPolicy;
import org.apache.hadoop.hdds.JsonTestUtils;
import org.apache.hadoop.hdds.cli.GenericCli;
import org.apache.hadoop.hdds.client.ReplicationType;
Expand All @@ -92,7 +93,6 @@
import org.apache.hadoop.ozone.ha.ConfUtils;
import org.apache.hadoop.ozone.om.OMConfigKeys;
import org.apache.hadoop.ozone.om.OzoneManager;
import org.apache.hadoop.ozone.om.TrashPolicyOzone;
import org.apache.hadoop.ozone.om.exceptions.OMException;
import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.apache.hadoop.ozone.om.helpers.OzoneFileStatus;
Expand Down Expand Up @@ -991,17 +991,17 @@ private OzoneConfiguration getClientConfForOFS(

/**
* Helper function to retrieve Ozone client configuration for ozone
* trash testing with TrashPolicyOzone.
* trash testing with OzoneTrashPolicy.
* @param hostPrefix Scheme + Authority. e.g. ofs://om-service-test1
* @param configuration Server config to generate client config from.
* @return Config ofs configuration added with fs.trash.classname
* = TrashPolicyOzone.
* = OzoneTrashPolicy.
*/
private OzoneConfiguration getClientConfForOzoneTrashPolicy(
String hostPrefix, OzoneConfiguration configuration) {
OzoneConfiguration clientConf =
getClientConfForOFS(hostPrefix, configuration);
clientConf.setClass("fs.trash.classname", TrashPolicyOzone.class,
clientConf.setClass("fs.trash.classname", OzoneTrashPolicy.class,
TrashPolicy.class);
return clientConf;
}
Expand Down Expand Up @@ -1186,7 +1186,7 @@ public void testDeleteTrashNoSkipTrash() throws Exception {

// Test delete from Trash directory removes item from filesystem

// setup configuration to use TrashPolicyOzone
// setup configuration to use OzoneTrashPolicy
// (default is TrashPolicyDefault)
final String hostPrefix = OZONE_OFS_URI_SCHEME + "://" + omServiceId;
OzoneConfiguration clientConf =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
* of TrashPolicy ozone-specific trash optimizations are/will be made such as
* having a multithreaded TrashEmptier.
*/
public class TrashPolicyOzone extends OzoneTrashPolicy {
class TrashPolicyOzone extends OzoneTrashPolicy {

private static final Logger LOG =
LoggerFactory.getLogger(TrashPolicyOzone.class);
Expand All @@ -60,10 +60,7 @@ public class TrashPolicyOzone extends OzoneTrashPolicy {
new SimpleDateFormat("yyMMddHHmm");
private long emptierInterval;

private OzoneManager om;

public TrashPolicyOzone() {
}
private final OzoneManager om;

@Override
public void initialize(Configuration conf, FileSystem fs) {
Expand Down