Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,15 @@
import org.apache.hadoop.hdds.conf.StorageSize;
import org.apache.hadoop.hdds.tracing.TracingUtil;
import org.apache.hadoop.ozone.OzoneConsts;
import org.apache.hadoop.ozone.client.BucketArgs;
import org.apache.hadoop.ozone.client.ObjectStore;
import org.apache.hadoop.ozone.client.OzoneBucket;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.client.OzoneClientFactory;
import org.apache.hadoop.ozone.client.OzoneVolume;
import org.apache.hadoop.ozone.client.io.OzoneInputStream;
import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.apache.hadoop.ozone.util.ShutdownHookManager;
import org.apache.hadoop.util.Time;
import org.apache.hadoop.util.VersionInfo;
Expand Down Expand Up @@ -191,6 +193,12 @@ public final class RandomKeyGenerator implements Callable<Void>, FreonSubcommand
)
private boolean cleanObjects = false;

@Option(
names = "--bucket-layout",
description = "Specifies the bucket layout (e.g., FILE_SYSTEM_OPTIMIZED, OBJECT_STORE, LEGACY)."
)
private BucketLayout bucketLayout;

private ReplicationConfig replicationConfig;

private int threadPoolSize;
Expand Down Expand Up @@ -646,6 +654,16 @@ long getUnsuccessfulValidationCount() {
return validateWrites ? writeValidationFailureCount.get() : 0;
}

/**
* Returns the current size of the buckets map.
*
* @return number of buckets created and added to the map
*/
@VisibleForTesting
int getBucketMapSize() {
return buckets.size();
}

/**
* Wrapper to hold ozone keyValidate entry.
*/
Expand Down Expand Up @@ -757,7 +775,14 @@ private boolean createBucket(int globalBucketNumber) {
.createActivatedSpan("createBucket")) {

long start = System.nanoTime();
volume.createBucket(bucketName);
if (bucketLayout != null) {
BucketArgs bucketArgs = BucketArgs.newBuilder()
.setBucketLayout(bucketLayout)
.build();
volume.createBucket(bucketName, bucketArgs);
} else {
volume.createBucket(bucketName);
}
long bucketCreationDuration = System.nanoTime() - start;
histograms.get(FreonOps.BUCKET_CREATE.ordinal())
.update(bucketCreationDuration);
Expand Down Expand Up @@ -880,7 +905,8 @@ private OzoneVolume getVolume(Integer volumeNumber) {
return waitUntilAddedToMap(volumes, volumeNumber);
}

private OzoneBucket getBucket(Integer bucketNumber) {
@VisibleForTesting
OzoneBucket getBucket(Integer bucketNumber) {
return waitUntilAddedToMap(buckets, bucketNumber);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

import org.apache.hadoop.ozone.client.OzoneBucket;
import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.apache.ozone.test.NonHATests;
import org.junit.jupiter.api.Test;
import picocli.CommandLine;
Expand Down Expand Up @@ -185,4 +187,25 @@ void cleanObjectsTest() {
assertEquals(2, randomKeyGenerator.getNumberOfVolumesCleaned());
assertEquals(6, randomKeyGenerator.getNumberOfBucketsCleaned());
}

@Test
void testBucketLayoutOption() {
RandomKeyGenerator randomKeyGenerator =
new RandomKeyGenerator(cluster().getConf());
CommandLine cmd = new CommandLine(randomKeyGenerator);
cmd.execute("--num-of-volumes", "1",
"--num-of-buckets", "1",
"--num-of-keys", "2",
"--bucket-layout", "OBJECT_STORE"
);

assertEquals(1, randomKeyGenerator.getNumberOfVolumesCreated());
assertEquals(1, randomKeyGenerator.getNumberOfBucketsCreated());
assertEquals(2, randomKeyGenerator.getNumberOfKeysAdded());
assertEquals(1, randomKeyGenerator.getBucketMapSize());

// Fetch the bucket and check its layout
OzoneBucket bucket = randomKeyGenerator.getBucket(0);
assertEquals(BucketLayout.OBJECT_STORE, bucket.getBucketLayout());
}
}
Loading