Skip to content

HDDS-12817. Add EC block index in the ozone debug replicas chunk-info #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssulav merged 2 commits into from
May 28, 2025
Merged

HDDS-12817. Add EC block index in the ozone debug replicas chunk-info #8515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08018e
HDDS-12817: Add EC block index in the ozone debug replicas chunk-info
ssulav May 28, 2025
a8e95f5
Add index comment lines as earlier
ssulav May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions ...one/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/chunk/ChunkKeyHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,13 @@ protected void execute(OzoneClient client, OzoneAddress address)
}

if (isECKey) {
ChunkType blockChunksType = isECParityBlock(keyPipeline, entry.getKey()) ?
ChunkType.PARITY : ChunkType.DATA;
jsonObj.put("chunkType", blockChunksType.name());
int replicaIndex = keyPipeline.getReplicaIndex(entry.getKey());
int dataCount = ((ECReplicationConfig) keyPipeline.getReplicationConfig()).getData();
// Index is 1-based,
// e.g. for RS-3-2 we will have data indexes 1,2,3 and parity indexes 4,5
ChunkType chunkType = (replicaIndex > dataCount) ? ChunkType.PARITY : ChunkType.DATA;
jsonObj.put("chunkType", chunkType.name());
jsonObj.put("ecIndex", replicaIndex);
Copy link
Contributor

@errose28 errose28 May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the term "replicaIndex" which is standard across the code base. Can we do an addendum to this change?

Copy link
Contributor Author

@ssulav ssulav May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let me add.

}
}
} catch (InterruptedException e) {
Expand All @@ -205,11 +209,4 @@ protected void execute(OzoneClient client, OzoneAddress address)
System.out.println(prettyJson);
}
}

private boolean isECParityBlock(Pipeline pipeline, DatanodeDetails dn) {
//index is 1-based,
//e.g. for RS-3-2 we will have data indexes 1,2,3 and parity indexes 4,5
return pipeline.getReplicaIndex(dn) >
((ECReplicationConfig) pipeline.getReplicationConfig()).getData();
}
}