Skip to content

HDDS-13075. Fix default value in description of container placement policy configs #8511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 3 commits into from
May 28, 2025
Merged

HDDS-13075. Fix default value in description of container placement policy configs #8511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c181c22
HDDS-13075. Update the description of ozone.scm.container.placement.i…
May 22, 2025
253975e
Updated default container placement policy
May 27, 2025
11b3296
Removed todo comment
May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hadoop-hdds/common/src/main/resources/ozone-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@
The full name of class which implements
org.apache.hadoop.hdds.scm.PlacementPolicy.
The class decides which datanode will be used to host the container replica. If not set,
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRackAware will be used as default
value.
</description>
</property>
Expand All @@ -928,7 +928,7 @@
The full name of class which implements
org.apache.hadoop.hdds.scm.PlacementPolicy.
The class decides which datanode will be used to host the container replica in EC mode. If not set,
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRackScatter will be used as default
value.
</description>
</property>
Expand Down
3 changes: 1 addition & 2 deletions ...pache/hadoop/hdds/scm/container/placement/algorithms/ContainerPlacementPolicyFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public final class ContainerPlacementPolicyFactory {

private static final Class<? extends PlacementPolicy>
OZONE_SCM_CONTAINER_PLACEMENT_IMPL_DEFAULT =
SCMContainerPlacementRandom.class;
SCMContainerPlacementRackAware.class;
private static final Class<? extends PlacementPolicy>
OZONE_SCM_CONTAINER_PLACEMENT_EC_IMPL_DEFAULT =
SCMContainerPlacementRackScatter.class;
Expand All @@ -62,7 +62,6 @@ public static PlacementPolicy getECPolicy(
ConfigurationSource conf, final NodeManager nodeManager,
NetworkTopology clusterMap, final boolean fallback,
SCMContainerPlacementMetrics metrics) throws SCMException {
// TODO: Change default placement policy for EC
final Class<? extends PlacementPolicy> placementClass = conf
.getClass(ScmConfigKeys.OZONE_SCM_CONTAINER_PLACEMENT_EC_IMPL_KEY,
OZONE_SCM_CONTAINER_PLACEMENT_EC_IMPL_DEFAULT,
Expand Down