HDDS-3418. Enable TestNodeFailure test cases. #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandakumar131
force-pushed
the
HDDS-3418
branch
from
a4ae8c7 to
416ff6c
Compare
dineshchitlangia
approved these changes
Apr 23, 2020
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 @nandakumar131 thanks for enabling and fixing this test.
Since you have specifically requested reviews from Bharat/Mukul, I will not merge it as yet :)
Member
|
#b7bf626 failure is related to the |
Member
Thanks the review @dineshchitlangia @bharatviswa504 / @mukul1987 I am planning to commit this tomorrow if you have no objections. |
Contributor
Author
|
Thanks for review @elek and @dineshchitlangia. |
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and enabled TestNodeFailure test cases
https://issues.apache.org/jira/browse/HDDS-3418