Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2025

Bumps software.amazon.awssdk:bom from 2.31.25 to 2.31.40.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps software.amazon.awssdk:bom from 2.31.25 to 2.31.40.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-version: 2.31.40
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 10, 2025
@adoroszlai adoroszlai changed the title Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.40 HDDS-12913. Bump awssdk to 2.31.40 May 10, 2025
@adoroszlai adoroszlai requested a review from ivandika3 May 10, 2025 19:59
@adoroszlai
Copy link
Contributor

#8338 (review):
AWS SDK V2 2.31.27 added a support for etag validation in resumableFileDownload
We might need to add a test for this first before merging this.

@ivandika3 Please correct me if I'm wrong, but if the library version Ozone currently uses does not have this, we cannot add the test before upgrade. So it seems #8455 will be adding the test and upgrading, too.

@adoroszlai adoroszlai closed this May 15, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 15, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot-maven-software.amazon.awssdk-bom-2.31.40 branch May 15, 2025 08:24
@ivandika3
Copy link
Contributor

@adoroszlai Thanks for checking this.

Please correct me if I'm wrong, but if the library version Ozone currently uses does not have this, we cannot add the test before upgrade. So it seems #8455 will be adding the test and upgrading, too.

Yes, we can upgrade it with the #8455 patch.

@adoroszlai
Copy link
Contributor

On second thought, I think in the future we should upgrade and add new test separately.

  • focused commits:
    • easier to backport
    • clean commit message
  • library upgrade can be merged quickly, while adding the test takes more time, review etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants