Skip to content

HDDS-13000. [Snapshot] listSnapshotDiffJobs throws NPE. #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 3 commits into from
May 13, 2025
Merged

HDDS-13000. [Snapshot] listSnapshotDiffJobs throws NPE. #8418

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c032b3
HDDS-13000. [Snapshot] listSnapshotDiffJobs throws NPE.
jojochuang May 8, 2025
f9d8aac
Handle other potential null pointer cases.
jojochuang May 13, 2025
d325ea2
Merge remote-tracking branch 'origin/master' into HDDS-13000
adoroszlai May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotDiffJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ public int hashCode() {
}

public SnapshotDiffJobProto toProtoBuf() {
return SnapshotDiffJobProto.newBuilder()
SnapshotDiffJobProto.Builder builder = SnapshotDiffJobProto.newBuilder()
.setCreationTime(creationTime)
.setJobId(jobId)
.setStatus(status.toProtobuf())
Comment thread
ivandika3 marked this conversation as resolved.
Outdated
Expand All @@ -269,9 +269,11 @@ public SnapshotDiffJobProto toProtoBuf() {
.setForceFullDiff(forceFullDiff)
.setDisableNativeDiff(disableNativeDiff)
.setTotalDiffEntries(totalDiffEntries)
.setSubStatus(subStatus.toProtoBuf())
.setKeysProcessedPct(keysProcessedPct)
.build();
.setKeysProcessedPct(keysProcessedPct);
if (subStatus != null) {
builder.setSubStatus(subStatus.toProtoBuf());
}
Comment thread
ivandika3 marked this conversation as resolved.
return builder.build();
Comment thread
jojochuang marked this conversation as resolved.
}

public static SnapshotDiffJob getFromProtoBuf(
Expand Down