HDDS-12938. Refactor OneReplicaPipelineSafeModeRule to not use PipelineReportFromDatanode #8410
Conversation
…neReportFromDatanode.
|
|
||
| for (Pipeline pipeline : openRatisPipelines) { | ||
| PipelineID pipelineID = pipeline.getId(); | ||
| boolean allDNsPipelineReported = pipeline.getNodeSet().size() == 3; |
There was a problem hiding this comment.
Could you explain why line 195 check is added? The old logic seems not check that. TIA!
There was a problem hiding this comment.
This check ensures that all three DN have reported that particular pipeline. We can do pipeline.getNodeSet().size() > 1 to check for at least one replica!
| } | ||
|
|
||
| @VisibleForTesting | ||
| public DatanodeDetails removeFirstFromNodeStatus() { |
There was a problem hiding this comment.
I think these two removeFirstFromNodeStatus and setInNodeStatus can be removed. To make a 2-node pipeline, use pipelineManager.deletePipeline to delete original one and add a 2-node one back through it.
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
2 participants
What changes were proposed in this pull request?
Currently, OneReplicaPipelineSafeModeRule depends on processing of PipelineReportFromDatanode to validate the rule. We should avoid processing any reports in Safamode rule and depend on the PipelineManager here.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12938
How was this patch tested?
Tested Manually.