Skip to content

HDDS-12951. EC: Log when falling back to reconstruction read #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
May 8, 2025
Merged

HDDS-12951. EC: Log when falling back to reconstruction read #8408

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff173ee
Add logging to ec read happy path
Galsza May 6, 2025
e66305f
Make logging less verbose and only log when reconstruction happens
Galsza May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ private synchronized void setReaderType() {
int expected = expectedDataLocations(repConfig, getLength());
int available = availableDataLocations(blockInfo.getPipeline(), expected);
reconstructionReader = available < expected;
LOG.info("Available data locations: {}, Expected data locations: {}. Based on this online reconstruction is: {}",
available, expected, reconstructionReader ? "triggered." : "not triggered.");
Copy link
Contributor

@adoroszlai adoroszlai May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the message is needed for normal ("not triggered") case. Also, please reduce verbosity, something like:

Data locations available: {} < expected: {}, using reconstruction read

}

private void createBlockReader() {
Expand Down